Add customizable band colors with local persistence and map legend editor; apply colors across map and DX views#441
Conversation
|
The amount of changes in this PR with regard to quotation mark styles, formatting, etc. makes me feel that some developers are using auto formatting. If we use autoformatting, what standards should we use? My preference is to commit a prettierrc to the codebase and allow it to be part of either the CI, part of the commit process (using githooks), or just as part of a developer's routine. The goal with doing so is to limit the amount of 'cruft' that is found in a PR and to improve code review. Thoughts? |
|
@denete - Totally agree. The quotation/formatting churn in PRs is a strong signal we’re already auto-formatting, just inconsistently. I’m actually already trying to move us in that direction in PR #402 by adding a standard .prettierrc and .editorconfig to the repo. I’d strongly prefer we make formatting deterministic and shared across the team (rather than “whatever my IDE feels like today”). Without Prettier + EditorConfig, merges and reviews turn into unnecessary friction, and diffs become noisy. In terms of enforcement: my vote is Prettier in CI (so it’s consistent and unavoidable), plus pre-commit / githooks (optional but recommended) to give fast feedback locally. That should drastically reduce cruft in PRs and make code review focus on logic instead of whitespace. Cc @accius |
This PR introduces a full user-customizable band color system and wires it into the existing UI. Requested in #358.
src/utils/bandColors.js) with:openhamclock_bandColorsgetBandColor()insrc/utils/callsign.jsto use the centralized color logic.src/components/WorldMap.jsx):src/App.jsx.src/layouts/ClassicLayout.jsxwith centralized band color lookups.2mand70cm.openhamclock_bandColorsto synced/snapshotted settings:src/utils/config.js(settings sync keys)src/utils/profiles.js(profile snapshot keys)src/components/WorldMap.jsxand language files:Sonne,MondSun,Moon