revert: remove duplicated !reset conversation-close from bots#32
Merged
achetronic merged 1 commit intomasterfrom Apr 18, 2026
Merged
revert: remove duplicated !reset conversation-close from bots#32achetronic merged 1 commit intomasterfrom
achetronic merged 1 commit intomasterfrom
Conversation
The previous commit (3528d6b) duplicated logic that had already been implemented on 2026-04-10 by commit 75cc2de. The ConversationRecorder middleware intercepts every session DELETE and calls Executor.CloseConversationSession, which already handles both admin and user perspectives for every client and for the admin API alike. Reverted: - SetConversationStore + closeConversations in telegram/slack/discord bots - conversations field + wiring in clientManager (main.go) Remaining wins from the previous commit stay in place: - Telegram thread-aware error messages (MessageThreadID on error paths) - Slack/Discord multimodal inlineData support - MemoryCard border polish (final form: no active override) Added decision #22 to .agents/DECISIONS.md pinning the middleware-based design and listing the "do not" rules so this mistake is not repeated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous commit (3528d6b) duplicated logic that had already been implemented on 2026-04-10 by commit 75cc2de. The ConversationRecorder middleware intercepts every session DELETE and calls Executor.CloseConversationSession, which already handles both admin and user perspectives for every client and for the admin API alike.
Reverted:
Remaining wins from the previous commit stay in place:
Added decision #22 to .agents/DECISIONS.md pinning the middleware-based design and listing the "do not" rules so this mistake is not repeated.