Packaging fixes#11
Open
Flameeyes wants to merge 4 commits into
Open
Conversation
This makes the code follow the REUSE.software specifications, which allow safe and low-friction reuse of code.
This pretty covers the whole content of the previous setup.py file, but as a declarative file, that does not require to execute code to run.
While the classifiers already included the supported Python version and the license, they are not actually built into the wheel. Add an explicit license metadata and a python_requires option.
This just makes it pass flake8 if used identically in tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your library! I'm looking to use it in a couple of places, so I thought I would send a couple of cleanups on the packaging side.
The SPDX tags are to make it easier to do license validation (see this blog post of mine), and making sure your copyright doesn't get buried behind imports.
The declarative setuptools file makes it easier to read information programmatically, and I found it easier to maintain long term.
If that interests you, I'm also happy to add, or send you a new pull request with, the pre-commit and GitHub Actions integration to make sure that the project stays REUSE compliant in the future.