Fix two bugs in bin/fasta-identity-table.py#855
Merged
terrycojones merged 5 commits intoacorg:masterfrom Apr 9, 2026
Merged
Conversation
imLew
approved these changes
Apr 9, 2026
| ## 7.1.15 January 23, 2026 | ||
|
|
||
| Added Claude-written `bin/plot-sam-coverage-depth.py` and tests. | ||
| >>>>>>> master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were (at least) two bugs introduced in this https://github.com/acorg/dark-matter/pull/781/changes both of which are (hopefully!) fixed here.
One was repeatedly putting the wrong read into a dict https://github.com/acorg/dark-matter/pull/781/changes#diff-a5286d3ade34112a1b582838570f7b4b4e567807df2549a274ee6c52caeaa223R970
The other was comparing sequence row and column numbers instead of the sequence IDs: https://github.com/acorg/dark-matter/pull/781/changes#diff-a5286d3ade34112a1b582838570f7b4b4e567807df2549a274ee6c52caeaa223R293
Sorry there are no tests! I don't even know if the code I just changed will work, but I will check soon once I can easily use these changes. I know, I know...