Add schema class naming strategy#14
Open
lucasrcosta wants to merge 2 commits intoacryldata:masterfrom
Open
Conversation
lucasrcosta
force-pushed
the
class-naming-strategy
branch
from
a0c2018 to
49b0c81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, thank you very much for adding Python 3 support for this project!
The use case I've been working on has a schema that requires me to customize the names of the generated classes to work properly.
This PR adds an optional
class_naming_strategyparameter to thegenerate_schemaschema function (and subsequent relevant calls) that receives another function to be used as the strategy for resolving the name of the class from the full name of the field.Cheers! 🎉