feat(chart)!: change default service type to ClusterIP#661
feat(chart)!: change default service type to ClusterIP#661CatherineThompson wants to merge 1 commit intoacryldata:masterfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Free Tier Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
51d594a to
a83aa58
Compare
default datahub-frontend and datahub-gms to ClusterIP for better security. this prevents unintentional public exposure on initial deployment. BREAKING CHANGE: the default service type is no longer LoadBalancer. users requiring external access must now explicitly set service.type to LoadBalancer or configure an Ingress. Closes acryldata#659
a83aa58 to
27903be
Compare
|
You have used all of your free Bugbot PR reviews. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
|
This PR is stale. We will close it in 30 days if there is no comment or activity. If you want feedback but not able to get it on github please head to #contribute channel in slack at https://slack.datahubproject.io. |
default datahub-frontend and datahub-gms to ClusterIP for better security. this prevents unintentional public exposure on initial deployment.
BREAKING CHANGE: the default service type is no longer LoadBalancer. users requiring external access must now explicitly set service.type to LoadBalancer or configure an Ingress.
Closes #659
Checklist
Note
Medium Risk
Breaking Helm chart default: new installs will no longer create external
LoadBalancerservices for GMS/frontend, which can surprise users relying on automatic public exposure. Change is configuration-only but affects networking/accessibility on upgrade or fresh deploys.Overview
Changes the default Kubernetes Service type for
datahub-gmsanddatahub-frontendfromLoadBalancertoClusterIP, reducing accidental public exposure and requiring users to explicitly opt intoLoadBalanceror use Ingress for external access.Bumps the parent chart version to
0.9.0and updatesdatahub-gms/datahub-frontendsubchart versions to0.4.0, plus updates the values reference and subchart READMEs to reflect the new defaults.Written by Cursor Bugbot for commit a83aa58. This will update automatically on new commits. Configure here.