feat(helm): add GraphQL shape logging configuration#686
Open
bart-agent[bot] wants to merge 5 commits intomasterfrom
Open
feat(helm): add GraphQL shape logging configuration#686bart-agent[bot] wants to merge 5 commits intomasterfrom
bart-agent[bot] wants to merge 5 commits intomasterfrom
Conversation
Add support for GraphQL shape logging feature with configurable thresholds: - enabled: false (default, opt-in feature) - fieldCountThreshold: 100 - durationThresholdMs: 3000 - responseSizeThresholdBytes: 1048576 - errorCountThreshold: 1 This mirrors the configuration added in datahub-project/datahub#16876 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add documentation for GraphQL shape logging configuration values: - graphql.shapeLogging.enabled - graphql.shapeLogging.fieldCountThreshold - graphql.shapeLogging.durationThresholdMs - graphql.shapeLogging.responseSizeThresholdBytes - graphql.shapeLogging.errorCountThreshold Also includes graphql.introspection.enabled entry that was missing. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This version bump is required by the Helm chart lint workflow which enforces that chart versions must be incremented when changes are made to the chart.
kewats
approved these changes
Apr 2, 2026
added 2 commits
April 2, 2026 13:42
- Removed GraphQL introspection config (not part of original PR scope) - Fixed VALUES_REFERENCE.md paths: datahub-gms.graphql → global.datahub.gms.graphql - Removed introspection documentation entirely - Only shape logging config remains as originally requested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for GraphQL shape logging configuration to the DataHub Helm chart, mirroring the feature added in datahub-project/datahub#16876.
Changes
Added to
values.yaml:Added to
deployment.yaml:GRAPHQL_SHAPE_LOGGING_ENABLEDGRAPHQL_SHAPE_FIELD_COUNT_THRESHOLDGRAPHQL_SHAPE_DURATION_THRESHOLD_MSGRAPHQL_SHAPE_RESPONSE_SIZE_THRESHOLD_BYTESGRAPHQL_SHAPE_ERROR_COUNT_THRESHOLDConfiguration Details
enabledfalsefieldCountThreshold100durationThresholdMs3000responseSizeThresholdBytes1048576errorCountThreshold1Related
🤖 Generated with Claude Code