feat(zdu): add ZDU flags and rollback dual-write configuration#689
Merged
feat(zdu): add ZDU flags and rollback dual-write configuration#689
Conversation
chakru-r
force-pushed
the
cr-add-zdu-support
branch
from
7dc4ebd to
eb13b93
Compare
RyanHolstien
approved these changes
Apr 10, 2026
Contributor
RyanHolstien
left a comment
RyanHolstien
left a comment
There was a problem hiding this comment.
We're leaving the other features off for now? Otherwise I'd expect feature specific ones in the zdu enable blocks.
Exposes ZDU group flags introduced in the zero-downtime upgrade branch: - global.datahub.systemUpdate.zdu.preEnable → ZDU_STAGE_10 (enables CREATE_SCHEMA_VERSION_INDEX for schema version index on metadata_aspect_v2) - global.datahub.systemUpdate.zdu.enable → ZDU_STAGE_20 (enables ELASTICSEARCH_BUILD_INDICES_INCREMENTAL_REINDEX_ENABLED, ELASTICSEARCH_BUILD_INDICES_ROLLBACK_DUAL_WRITE_ENABLED, SYSTEM_UPDATE_MIGRATE_ASPECTS_ENABLED, and ASPECT_MIGRATION_MUTATOR_ENABLED) - Setting zdu.enable=true automatically disables scaleDown operations in both blocking and nonblocking system-update jobs - ZDU_STAGE_20 also propagated to GMS deployment for runtime aspect migration mutator chain activation - global.elasticsearch.index.upgrade.rollbackDualWriteEnabled exposed as an explicit per-flag override for ELASTICSEARCH_BUILD_INDICES_ROLLBACK_DUAL_WRITE_ENABLED Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
When zdu.enable=true, ELASTICSEARCH_BUILD_INDICES_ALLOW_DOC_COUNT_MISMATCH is automatically forced to true in both system-update job container specs. The individual allowDocCountMismatch value is only respected when zdu.enable is not set. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
chakru-r
force-pushed
the
cr-add-zdu-support
branch
from
eb13b93 to
c90d003
Compare
Contributor
Author
I added one more for allowDocCountMismatch to be set when zduStage20 is enabled. ARe there any others required now? I will enable the zduPreenable default to true closer to a release -- otherwise, other fixes being made now can be used with already released versions. |
david-leifker
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes ZDU group flags introduced in the zero-downtime upgrade branch:
ELASTICSEARCH_BUILD_INDICES_ALLOW_DOC_COUNT_MISMATCH is automatically forced to true in both The individual allowDocCountMismatch value is only respected when zdu.enable is not set.
Checklist