fix(helm): decouple allowDocCountMismatch from zdu.enable#696
Merged
fix(helm): decouple allowDocCountMismatch from zdu.enable#696
Conversation
The flag can now be set independently; remove the conditional that forced it to true whenever zdu.enable was set. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
RyanHolstien
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ELASTICSEARCH_BUILD_INDICES_ALLOW_DOC_COUNT_MISMATCH=truewheneverzdu.enable=trueallowDocCountMismatchis now always driven solely byglobal.elasticsearch.index.upgrade.allowDocCountMismatch0.9.10Test plan
helm templatewithzdu.enable=true+allowDocCountMismatch=truerenders env var as"true"helm templatewithzdu.enable=false+allowDocCountMismatch=truerenders env var as"true"helm templatewithallowDocCountMismatchunset (defaultfalse) renders no env var regardless ofzdu.enable🤖 Generated with Claude Code