Skip to content

docs(agents): clarify work-on-main applies to maintainers, not fork contributors - #7

Open
levonk wants to merge 1 commit into
acryldev:mainfrom
levonk:fix/agents-third-party-branch-exception
Open

docs(agents): clarify work-on-main applies to maintainers, not fork contributors#7
levonk wants to merge 1 commit into
acryldev:mainfrom
levonk:fix/agents-third-party-branch-exception

Conversation

@levonk

@levonk levonk commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add explicit clause to AGENTS.md line 29 clarifying that the "work directly on main" convention applies to maintainers with push access, not to third-party contributors on forks who must use feature branches and PRs.

Context

The "work directly on main" instruction was set during an internal small-team rapid-development phase (blame: 27356dcc). AI agents and other third-party contributors working on forks follow AGENTS.md by default, and this line causes them to commit to main on the fork instead of creating a feature branch — making it impossible to open a clean PR upstream without retroactive history surgery.

See #6 for the full problem description.

Closes #6

@musichen musichen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for identifying the fork-contributor gap. I agree with the requested AGENTS.md clarification.

Requesting changes before merge:

  • Rebase onto current main.
  • Limit this PR to the contributor-branch clarification and any directly related documentation.
  • Remove the unrelated ACP/Devin changes from this branch.

The current CI failure is also material: the profile cannot resolve @deepseek-ai/dsh-subagent-acp while loading subagent-acp-devin. That belongs in its own scoped PR with its dependency and Loader-composition verification.

@levonk
levonk force-pushed the fix/agents-third-party-branch-exception branch from 19ff8ce to d12fe85 Compare September 9, 2026 23:30
@levonk
levonk marked this pull request as draft September 9, 2026 23:31
…ontributors

The "work directly on main" convention in AGENTS.md line 29 was set for
internal small-team rapid development. Third-party contributors on forks
cannot push to main upstream and must work on feature branches to open PRs.
Add an explicit clause so agents reading AGENTS.md on a fork don't commit
to main when a PR is the intended delivery path.

Closes acryldev#6
@levonk
levonk force-pushed the fix/agents-third-party-branch-exception branch from d12fe85 to efd779e Compare September 9, 2026 23:33
@levonk

levonk commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

Sorry for the mixed workstreams on this branch — and thanks for the clear review. Here's what I did to resolve each request:

  • Rebased onto current main (080b89c) — the branch now sits cleanly on upstream main with no merge noise.
  • Removed the unrelated ACP/Devin commits — the acryl ACP server, Devin subagent via ACP, and their dev-log entries are dropped from this PR. The dsh-subagent-acp dependency and Loader-composition verification will go in a separate scoped PR.
  • Limited to the contributor-branch clarification — the PR is now a single commit touching one line of AGENTS.md.

The CI failure from the unresolved dsh-subagent-acp dependency should clear now that those commits are gone. Thanks again for catching this.

@levonk
levonk marked this pull request as ready for review September 9, 2026 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AGENTS.md "work directly on main" sabotages third-party agent contributors

2 participants