fix: Some applications' (Microsoft Word) closing event not detected#372
Open
AdamGaskins wants to merge 1 commit into
Open
fix: Some applications' (Microsoft Word) closing event not detected#372AdamGaskins wants to merge 1 commit into
AdamGaskins wants to merge 1 commit into
Conversation
AdamGaskins
changed the title
AdamGaskins
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have the great privilege (sarcasm) of using Microsoft Products at work, but when clicking X, Rift would leave empty space for them until the next time stale windows were cleared. This was happening for me in Microsoft Teams, Excel, Powerpoint and Word.
The issue seems to be that when these particular windows are closed, a WindowClosed event is not being fired, but only a
kAXUIElementDestroyedNotificationevent. However in akAXUIElementDestroyedNotificationevent, the window has already been destroyed, so trying to get the window/process id returnsAXError(-25202) kAXErrorInvalidUIElement.A few years ago, AeroSpace stopped removing windows on
kAXUIElementDestroyedNotificationevents and instead just refreshing the window list. Commit | Current status of mainThis PR is a 1 line change to implement the same thing, and from my testing solves the issue.