[14.0][IMP] stachechart_mixin: make it possible to ignore some events in the has_allowed_event compute#40
[14.0][IMP] stachechart_mixin: make it possible to ignore some events in the has_allowed_event compute#40jdoutreloux wants to merge 2 commits into
Conversation
sbejaoui
left a comment
sbejaoui
left a comment
There was a problem hiding this comment.
It's a somewhat tricky solution. I didn't like the fact that it depends on the context.
As I understand it, we are trying to exclude certain events from the user notification/dashboard. I prefer a more explicit field than the priority. For example: "exclude_from_allowed_event." takes true or false.
|
|
||
| @api.depends("sc_state") | ||
| def _compute_sc_has_allowed_events(self): | ||
| priorities = self.env.context.get("priorities") |
There was a problem hiding this comment.
| priorities = self.env.context.get("priorities") | |
| priorities = self.env.context.get("priorities", []) |
jdoutreloux
force-pushed
the
14.0-imp_has_allowed_events-jdo
branch
2 times, most recently
from
1c52070 to
e37e365
Compare
| def _get_sc_event_allowed_field_names(self): | ||
| event_names = self._statechart.events_for() | ||
| ignore_for_has_allowed_events = self.env.context.get("ignore_for_has_allowed_events", []) | ||
| event_names = [name for name in self._statechart.events_for() if name not in ignore_for_has_allowed_events] |
There was a problem hiding this comment.
nit: you can put the if name not in ignore_for_has_allowed_events in the return statement, to avoid creating a temporary list.
| return [ | ||
| _sc_make_event_allowed_field_name(event_name) for event_name in event_names | ||
| ] |
There was a problem hiding this comment.
| return [ | |
| _sc_make_event_allowed_field_name(event_name) for event_name in event_names | |
| ] | |
| return [ | |
| _sc_make_event_allowed_field_name(event_name) for event_name in event_names if event_name not in ignore_for_has_allowed_event | |
| ] |
jdoutreloux
force-pushed
the
14.0-imp_has_allowed_events-jdo
branch
from
e37e365 to
ee7254d
Compare
|
This needs a test. It should be easy to add in |
jdoutreloux
force-pushed
the
14.0-imp_has_allowed_events-jdo
branch
from
ee7254d to
c21bb32
Compare
Sorry for the delay, I'm just now seeing your review. I've added the test as you asked. |
jdoutreloux
force-pushed
the
14.0-imp_has_allowed_events-jdo
branch
from
c21bb32 to
15d918b
Compare
|
This PR has the |
1 similar comment
|
This PR has the |
sbidoul
changed the title
sbidoul
changed the title
… has_allowed_event compute
There is no need to leak this context handling to _get_sc_event_allowed_field_names, where this can be handled with a new argument.
sbidoul
force-pushed
the
14.0-imp_has_allowed_events-jdo
branch
from
209e40f to
4634de1
Compare
4 participants
This commits makes it possible to ignore some events when computing has_allowed_events by passing them in the context key
ignore_for_has_allowed_events.For example, our record has a cancel action on each state but we don't want to take that action into account when getting the records with allowed_events
Our use case is showing all the records that need an action in a dashboard. But the records with a cancel action are not actually in need of an action.