Skip to content

[FIX] reraise __cause__ of the CodeEvaluationError if it exists #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benwillig wants to merge 1 commit into from
Closed

[FIX] reraise __cause__ of the CodeEvaluationError if it exists #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions statechart/models/interpreter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,12 @@
from sismic.interpreter import Interpreter as SismicInterpreter
from sismic.model import Event

from odoo.exceptions import except_orm


def _root_cause(e):
if isinstance(e, except_orm):
return e
if not hasattr(e, "__cause__") or not e.__cause__:
return e
return _root_cause(e.__cause__)
cause_exc = getattr(e, "__cause__", None)
if cause_exc:
return cause_exc
return e
Comment on lines +12 to +15
Copy link
Copy Markdown
Member

@sbidoul sbidoul Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cause_exc = getattr(e, "__cause__", None)
if cause_exc:
return cause_exc
return e
return getattr(e, "__cause__", e)

This could be simplified like this, or even inlined at the two places where this is used, since the _root_cause name does not meany much anymore.

Copy link
Copy Markdown
Member

@sbidoul sbidoul Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, no. I need more coffee :)

Copy link
Copy Markdown
Member

@sbidoul sbidoul Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather, (e.__cause__ or e), because __cause__ is part of BaseException so getattr should not be necessary anymore.



class Interpreter(SismicInterpreter):
Expand Down