review修复：删除eval.dump的5.2 compat分支（undump不支持）；pcall保护仅限目标VM的dump产物

Author: sumneko

extension/script/backend/worker/eval.lua

@@ -43,23 +43,9 @@ local function generate(name, init)
 end
 
 generate("dump", function()
-    if luaver.LUAVERSION <= 52 then
-        local compat_dump = assert(load(readfile 'backend.worker.eval.dump'))
-        return function(content)
-            local ok, res, err = pcall(compat_dump, content)
-            if ok and res ~= nil then
-                return true, res
-            end
-            if ok then
-                return false, 'can not dump function.'
-            end
-            return false, res
-        end
-    else
-        local eval_dump = assert(rdebug.load(readfile 'backend.worker.eval.dump'))
-        return function(content)
-            return rdebug.eval(eval_dump, content, 0)
-        end
+    local eval_dump = assert(rdebug.load(readfile 'backend.worker.eval.dump'))
+    return function(content)
+        return rdebug.eval(eval_dump, content, 0)
     end
 end)
 

extension/script/backend/worker/parser.lua

@@ -96,25 +96,31 @@ end
 return function (content, syntaxCompatibility)
     local err
     local bin
+    local cl, v
     if syntaxCompatibility then
         bin, err = dumpTarget(content)
+        if not bin then
+            local log = require 'common.log'
+            log.error("ERROR:"..(err or "unknown error"))
+            return
+        end
+        local ok
+        ok, cl, v = pcall(undump, bin)
+        if not ok then
+            local log = require 'common.log'
+            log.error("ERROR:"..tostring(cl))
+            return
+        end
     else
         local f
         f, err = load(content)
-        if f then
-            bin = string.dump(f)
+        if not f then
+            local log = require 'common.log'
+            log.error("ERROR:"..(err or "unknown error"))
+            return
         end
-    end
-    if not bin then
-        local log = require 'common.log'
-        log.error("ERROR:"..(err or "unknown error"))
-        return
-    end
-    local ok, cl, v = pcall(undump, bin)
-    if not ok then
-        local log = require 'common.log'
-        log.error("ERROR:"..tostring(cl))
-        return
+        bin = string.dump(f)
+        cl, v = undump(bin)
     end
     version = v
     local si = { activelines = {}, definelines = {} }