feat: change azcopy script to download directly from github releases #13290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azcopy recently added a change which breaks static urls for downloading these assets. Refer: actions#13279 for more details.
Contributor
|
Oh, I see we're on the same page. 😄 I'm glad you're paying attention to the project and wanting to make it better—there's nothing more satisfying for a maintainer. There's a problem. We don't accept contributions to macOS for technical reasons. 😞 There are two options:
What would you prefer? 🤔 |
Author
|
@erik-bershel Let do co-author then, it would be best if we could add the changes for macos as well. |
4 tasks
Contributor
|
Closing in favor: #13297 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
azcopyscript currently uses a static URL for downloading. There seems to be a window during new releases of azcopy where the assets are available on github releases and a new release is also available but the static URL returns 404. I don't have full context of this static URL here, how it is patched to point to the releases, but this URL doesn't seem very robust. Switching to use the github releases assets would make for a more resilient script, adding the changes for that here.Related issue: #13279
Related issue:
Check list