Skip to content

Optimize deployment. #3116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khustup2 merged 4 commits into from
Jan 20, 2026
Merged

Optimize deployment. #3116

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4fdb44
Optimize deployment.
khustup2 Jan 16, 2026
03ae046
Merge branch 'main' into ci-cd-optimize
khustup2 Jan 19, 2026
f04442a
Merge branch 'main' into ci-cd-optimize
khustup2 Jan 20, 2026
ae0b58f
Merge branch 'main' into ci-cd-optimize
khustup2 Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 44 additions & 4 deletions .github/workflows/pg-extension-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ jobs:
build_container_images:
name: Build Container Images
if: github.event_name == 'workflow_dispatch'
needs: [setup, extension-build, repo-build]
needs: [setup, extension-build]
env:
OP_SERVICE_ACCOUNT_TOKEN: "${{ secrets.OP_SERVICE_ACCOUNT_TOKEN }}"
VERSION: "${{ needs.extension-build.outputs.version }}"
Expand All @@ -272,6 +272,49 @@ jobs:
- name: checkout
uses: actions/checkout@v6.0.1

- name: configure aws credentials
uses: aws-actions/configure-aws-credentials@v5.1.1
with:
role-to-assume: "arn:aws:iam::067976305224:role/github"
aws-region: us-east-1

- name: download build artifacts
shell: bash
run: |-
for arch in x86_64 aarch64; do
aws s3 cp "s3://activeloop-platform-tests/indra/artifacts/postgres/postgres-${arch}.tar" postgres-"${arch}".tar
tar xf postgres-"${arch}".tar
done

- name: build deb packages
shell: bash
env:
PG_VERSION: "${{ matrix.version }}"
VERSION: "${{ needs.extension-build.outputs.version }}"
run: |-
mkdir -p ./debs
for arch_pair in "amd64:x86_64" "arm64:aarch64"; do
ARCH="${arch_pair%%:*}"
ARTIFACT_DIR="postgres-${arch_pair##*:}"
DEB_PATH=$(mktemp -d)
mkdir -p "${DEB_PATH}/pg-deeplake-${PG_VERSION}/DEBIAN/"
mkdir -p "${DEB_PATH}/pg-deeplake-${PG_VERSION}/usr/lib/postgresql/${PG_VERSION}/lib/"
mkdir -p "${DEB_PATH}/pg-deeplake-${PG_VERSION}/usr/share/postgresql/${PG_VERSION}/extension/"
install -m 644 "${ARTIFACT_DIR}"/pg_deeplake_"${PG_VERSION}".so "${DEB_PATH}/pg-deeplake-${PG_VERSION}/usr/lib/postgresql/${PG_VERSION}/lib/pg_deeplake"

Copilot AI Jan 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source file includes a .so extension but the destination omits it. This creates pg_deeplake without the .so extension, which may cause PostgreSQL to fail loading the extension library. The destination should be pg_deeplake.so to match the expected library naming convention.

Suggested change
install -m 644 "${ARTIFACT_DIR}"/pg_deeplake_"${PG_VERSION}".so "${DEB_PATH}/pg-deeplake-${PG_VERSION}/usr/lib/postgresql/${PG_VERSION}/lib/pg_deeplake"
install -m 644 "${ARTIFACT_DIR}"/pg_deeplake_"${PG_VERSION}".so "${DEB_PATH}/pg-deeplake-${PG_VERSION}/usr/lib/postgresql/${PG_VERSION}/lib/pg_deeplake.so"

Copilot uses AI. Check for mistakes.
install -m 644 "${ARTIFACT_DIR}"/pg_deeplake*.sql "${DEB_PATH}/pg-deeplake-${PG_VERSION}/usr/share/postgresql/${PG_VERSION}/extension/"

Copilot AI Jan 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a wildcard pattern with install may fail if multiple SQL files match the pattern, as install expects a single source file when the destination is a directory. Consider using a loop or copying files individually to ensure all SQL files are properly installed.

Suggested change
install -m 644 "${ARTIFACT_DIR}"/pg_deeplake*.sql "${DEB_PATH}/pg-deeplake-${PG_VERSION}/usr/share/postgresql/${PG_VERSION}/extension/"
for sql_file in "${ARTIFACT_DIR}"/pg_deeplake*.sql; do
[ -e "${sql_file}" ] || continue
install -m 644 "${sql_file}" "${DEB_PATH}/pg-deeplake-${PG_VERSION}/usr/share/postgresql/${PG_VERSION}/extension/"
done

Copilot uses AI. Check for mistakes.
install -m 644 "${ARTIFACT_DIR}"/pg_deeplake.control "${DEB_PATH}/pg-deeplake-${PG_VERSION}/usr/share/postgresql/${PG_VERSION}/extension/"
printf '%s\n' \
"Package: pg-deeplake-${PG_VERSION}" \
"Version: ${VERSION}" \
"Section: database" \
"Priority: optional" \
"Architecture: ${ARCH}" \
"Maintainer: Activeloop SRE <sre@activeloop.dev>" \
"Description: PostgreSQL ${PG_VERSION} DeepLake Extension." \
> "${DEB_PATH}/pg-deeplake-${PG_VERSION}/DEBIAN/control"
dpkg --build "${DEB_PATH}/pg-deeplake-${PG_VERSION}" "./debs/pg-deeplake-${PG_VERSION}_${VERSION}-1_${ARCH}.deb"
done

- name: load 1pass
id: load-1pass
uses: 1password/load-secrets-action@v3.0.0
Expand All @@ -298,10 +341,7 @@ jobs:
PG_VERSION: "${{ matrix.version }}"
VERSION: "${{ needs.extension-build.outputs.version }}"
run: |-
mkdir -p ./debs
echo "Using package version: ${VERSION}"
wget https://packages.activeloop.io/deb/pg-deeplake/pool/main/pg-deeplake-"${PG_VERSION}"_"${VERSION}"-1_amd64.deb -O ./debs/pg-deeplake-"${PG_VERSION}"_"${VERSION}"-1_amd64.deb
wget https://packages.activeloop.io/deb/pg-deeplake/pool/main/pg-deeplake-"${PG_VERSION}"_"${VERSION}"-1_arm64.deb -O ./debs/pg-deeplake-"${PG_VERSION}"_"${VERSION}"-1_arm64.deb
sed s/BASE_IMAGE/postgres:"${PG_VERSION}"-bookworm/g postgres/Dockerfile > Dockerfile.build
docker buildx build \
--push \
Expand Down
Loading