Fix JSON integer decoding - #3047
Merged
Merged
Conversation
plajjan
marked this pull request as ready for review
July 30, 2026 21:51
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9c16e2bb83
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
yyjson_get_int truncates values to a 32-bit C int. Decode signed and unsigned integers with the 64-bit accessors, preserving positive values above int64 as u64.
plajjan
force-pushed
the
agent/fix-json-integer-decoding
branch
from
July 30, 2026 22:00
9c16e2b to
b097b4b
Compare
plajjan
enabled auto-merge
July 30, 2026 22:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JSON decoder used yyjson_get_int(), which converts parsed integers to a 32-bit C int and truncated values such as 1000000000000.
Use yyjson's 64-bit signed and unsigned accessors for both object and array decoding. Values in the signed range remain Acton ints, while larger positive integers decode as u64. Add regression coverage for signed, unsigned, and uint64 boundary values.