Conversation
Added lesson activity and integrated with main
* Add on-click listener for connect button * Removed bluefruit folder * Add FastBle dependency * Update dependencies * Added bluetooth functionality * Fix corrupt logo
Comment on lines
+59
to
+62
| public static BleDevice SignBuddy; | ||
| public static ReentrantLock samplesLock = new ReentrantLock(); | ||
| public static List<SignBuddyProto.SBPSample> samples = new ArrayList<>(); | ||
| public static ByteArrayOutputStream byteBuffer = new ByteArrayOutputStream(); |
Collaborator
There was a problem hiding this comment.
leave these as private and just redefine them in the other activity
Comment on lines
+95
to
+98
| public void onFinish() { | ||
| countText.setText("GO!"); | ||
| BleManager.getInstance().notify(MainActivity.SignBuddy, UUID_SERVICE, UUID_CHARACTERISTIC_NOTIFY, new BleNotifyCallback() { | ||
| @Override |
Collaborator
There was a problem hiding this comment.
Notify should be called before this somewhere. This is where you actually need to send the command to the device to record the data, and so the app should already be waiting to be notified
| } | ||
| } | ||
| }); | ||
| countText.setText(gestureData.toString()); |
Collaborator
There was a problem hiding this comment.
This will get called right away like this and so this string will likely be empty
| overridePendingTransition(0, 0); | ||
| } | ||
| else { | ||
| Toast.makeText(LessonActivity.this, "Incorrect, Please try again!", Toast.LENGTH_SHORT).show(); |
Collaborator
There was a problem hiding this comment.
I think toast is mostly used for debug info, I think these important messages should be displayed as text in the activity screen
| String data19 = String.valueOf((gestureData.getSamples(0).getTouchData().getTouch8() ? 1 : -1)/12.64911); | ||
| String data20 = String.valueOf((gestureData.getSamples(0).getTouchData().getTouch9() ? 1 : -1)/12.64911); | ||
| String[] args = {data0, data1, data2, data3, data4, data5, data6, data7, data8, data9, data10, data11, data12, data13, data14, data15, data16, data17, data18, data19, data20}; | ||
| SVCalpha = SVC.main(args)+1; |
Collaborator
There was a problem hiding this comment.
I don't think the +1 is necessary
Comment on lines
+220
to
+232
| private boolean checkCorrect() { | ||
|
|
||
| if (alphanum<=9){ | ||
| correct = (alphanum==SVCalpha); | ||
| } | ||
| //skip j | ||
| if (alphanum<26 && alphanum>10){ | ||
| correct = (alphanum==SVCalpha-1); | ||
| } | ||
| if (alphanum==10 || alphanum ==26) { | ||
| correct = true;//skip this letter | ||
| } | ||
| return correct; |
Collaborator
There was a problem hiding this comment.
This is kind of confusing, can you just define an enum for all of the letters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.