Skip to content

Implement URL configuration sharing#1

Open
rasteiner wants to merge 1 commit into
adamkiss:gh-pagesfrom
rasteiner:gh-pages
Open

Implement URL configuration sharing#1
rasteiner wants to merge 1 commit into
adamkiss:gh-pagesfrom
rasteiner:gh-pages

Conversation

@rasteiner
Copy link
Copy Markdown

@rasteiner rasteiner commented Dec 10, 2024

Introduce functionality to share a configuration via the URL hash, allowing users to load settings directly from a shared URL.

This includes parsing the hash to retrieve filters, keys, grouping, and templates on init, and updating the URL when settings change.

Pros:

  • you can share a config with co workers / clients
  • straight forward to share and implement without a server
  • you can bookmark them to save multiple configs

Cons:

  • The url is ugly
  • Bad actors could steal your data by sharing bad urls which contain bad javascript in the filters.
  • You loose your config stored in local storage if you visit such an url

I thought it could be nice, but idk if it's worth it.

@adamkiss adamkiss self-assigned this Dec 10, 2024
@adamkiss adamkiss added the enhancement New feature or request label Dec 10, 2024
@adamkiss
Copy link
Copy Markdown
Owner

Thanks Roman, I will think about this

@adamkiss
Copy link
Copy Markdown
Owner

I've come to conclusion that for safety reasons, you don't ever need to store the filters in the hash; there's no reason why you can't have filters you're not using; for backup reasons, you can save them elsewhere, but you really only need to make the template and optional grouping bookmarkable; data is fresh everytime anyway

That's my current thought process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants