Fix: Use correct method to uninstall plugins during rollback#189
Merged
Fix: Use correct method to uninstall plugins during rollback#189
Conversation
The rollback called `this.contentplugin.uninstallPlugin()` which does not exist on ContentPluginModule. The correct method is `delete()`. This caused a TypeError that masked the original import error and prevented proper cleanup of newly installed plugins.
|
🎉 This PR is included in version 2.5.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
this.contentplugin.uninstallPlugin()which does not exist onContentPluginModule— the correct method isdelete({ _id }). This caused aTypeErrorthat masked the original import error and prevented cleanup of newly installed plugins on failed imports.uninstallPluginmethod, which hid the bug from test coverage.installFrameworkandupdateFrameworkpassed a semver range (>=5.0.0 <6.0.0) directly to the CLI as a version tag. The CLI used this as a GitHub archive branch name, producing a 404. Now resolves the range to a concrete version viagetLatestVersion()first.getLatestFrameworkVersionparam should beversionLimitnotversion(refs Update: Allow versionLimit to be passed to getLatestFrameworkVersion (fixes #240) adaptlearning/adapt-cli#241).Testing
npx standardpasses