This repository was archived by the owner on Mar 27, 2026. It is now read-only.
Update: Remove unnecessary await from synchronous schema calls#64
Merged
Update: Remove unnecessary await from synchronous schema calls#64
Conversation
This was referenced Mar 24, 2026
Also removes await from schema.validate() and replaces Promise.allSettled with synchronous try/catch loop in storeSchemaSettings(), since processModuleSchema is now fully synchronous. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes adapt-security/adapt-authoring-jsonschema#58
Update
awaitfromcreateSchema().build()inprocessModuleSchema— both calls are now synchronous after adapt-schemas v3.0.0Testing
npm run devand verify module config schemas load without errorsnpm test