This repository was archived by the owner on Mar 27, 2026. It is now read-only.
Update: Replace jsonschema module dep with adapt-schemas#66
Closed
Update: Replace jsonschema module dep with adapt-schemas#66
Conversation
Drop the peer dependency on adapt-authoring-jsonschema and use the adapt-schemas library directly. Config only needs basic schema loading and validation which adapt-schemas provides natively, removing a potential circular dependency and simplifying the boot sequence.
Collaborator
Author
|
Superseded by adapt-security/adapt-authoring-core#112 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #65
Update
adapt-authoring-jsonschemapeer dependency with directadapt-schemasdependencystoreSchemaSettingsnow creates a localSchemasinstance instead of waiting for the jsonschema modulewaitForModule('jsonschema')call, simplifying boot order and eliminating potential circular dependencyTesting