Fix: exclude non-trackable models from checkCompletionStatusFor#532
Open
danielghost wants to merge 1 commit intomasterfrom
Open
Fix: exclude non-trackable models from checkCompletionStatusFor#532danielghost wants to merge 1 commit intomasterfrom
checkCompletionStatusFor#532danielghost wants to merge 1 commit intomasterfrom
Conversation
Member
|
_isTrackable should not be intertwined with completion or optionality, please fix this in trickle rather than core. Whether something is saved to the lms or not has nothing to do with whether it's complete or optional. |
ethan-lp
approved these changes
Jun 20, 2024
lemmyadams
approved these changes
Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #526.
Fix
checkCompletionStatusFor.New
getAvailableTrackableChildModelsto return only_isAvailable: trueand_isTrackable !== falsemodels.