Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #231
Fix
validateCorrectRange()method to SliderModel that runs duringinit(), beforesetupModelItems()_correctRangeconfigurations with console warnings:_bottom>_top) - values are swapped_scaleStart/_scaleEnd_scaleStepincrementTesting
_bottom: 9, _top: 4) - verify console warning and correct scoring_bottom: 50on a scale ending at 10) - verify clamping and warning_bottom: 3with_scaleStep: 2starting at 1) - verify snapping to nearest step_correctAnswermode is unaffected (validation skips when_correctAnsweris set)Performance Impact
None - validation runs once during
init()with O(1) operations