🧪 Add test for NewManager in internal/service

internal/service/service_test.go

@@ -0,0 +1,28 @@
+package service
+
+import (
+	"reflect"
+	"testing"
+)
+
+func TestNewManager(t *testing.T) {
+	variant := Variant{
+		ID:           "test-id",
+		Family:       "test-family",
+		Variant:      "Local",
+		RegistryName: "TestService",
+		DisplayName:  "Test Service Display",
+		ExeName:      "test.exe",
+		Binary:       []byte("test binary data"),
+	}
+
+	manager := NewManager(variant)
+
+	if manager == nil {
+		t.Fatal("NewManager returned nil")
+	}
+
+	if !reflect.DeepEqual(manager.variant, variant) {
+		t.Errorf("NewManager() = %v, want variant %v", manager.variant, variant)
+	}
+}

internal/ui/builders.go

@@ -91,10 +91,10 @@ func buildFamilyMenuItems(fs service.FamilyStatus) []list.Item {
 				data:        "install-remote",
 			},
 			menuItem{
-				title:       "Volver",
+				title:       LabelBack,
 				description: "Regresar al menú principal",
-				icon:        "[<]",
-				data:        "back",
+				icon:        IconBack,
+				data:        ActionBack,
 			},
 		}
 	}
@@ -130,15 +130,15 @@ func buildFamilyMenuItems(fs service.FamilyStatus) []list.Item {
 			title:       "Forzar Detención",
 			description: "El servicio está en transición — forzar detención",
 			icon:        "[!]",
-			data:        "force-stop",
+			data:        ActionForceStop,
 		})
 
 	case service.StatusUnknown:
 		items = append(items, menuItem{
 			title:       "Forzar Detención",
 			description: "Estado desconocido — intentar forzar detención del servicio",
 			icon:        "[!]",
-			data:        "force-stop",
+			data:        ActionForceStop,
 		})
 	default:
 		log.Printf("Estado inesperado para %s: %s", installed, status.String())
@@ -159,10 +159,10 @@ func buildFamilyMenuItems(fs service.FamilyStatus) []list.Item {
 			data:        "uninstall",
 		},
 		menuItem{
-			title:       "Volver",
+			title:       LabelBack,
 			description: "Regresar al menú principal",
-			icon:        "[<]",
-			data:        "back",
+			icon:        IconBack,
+			data:        ActionBack,
 		},
 	)
 
@@ -189,10 +189,10 @@ func buildLogsMenuItems() []list.Item {
 			data:        "open-dir",
 		},
 		menuItem{
-			title:       "Volver",
+			title:       LabelBack,
 			description: "Regresar al menú de servicio",
-			icon:        "[<]",
-			data:        "back",
+			icon:        IconBack,
+			data:        ActionBack,
 		},
 	}
 }

internal/ui/constants.go

@@ -0,0 +1,13 @@
+package ui
+
+// Shared constants for UI menu actions and labels to prevent goconst warnings.
+const (
+	// ActionBack is the data string used for navigating back.
+	ActionBack = "back"
+	// ActionForceStop is the data string used for forcing a service to stop.
+	ActionForceStop = "force-stop"
+	// LabelBack is the display title for back navigation options.
+	LabelBack = "Volver"
+	// IconBack is the standard icon used for back navigation options.
+	IconBack = "[<]"
+)

internal/ui/update.go

@@ -211,7 +211,7 @@ func (m Model) handleFamilyKey(msg tea.KeyMsg) (tea.Model, tea.Cmd) {
 		}
 
 		switch selected.data {
-		case "back":
+		case ActionBack:
 			return m.goToDashboard()
 
 		case "install-local":
@@ -236,7 +236,7 @@ func (m Model) handleFamilyKey(msg tea.KeyMsg) (tea.Model, tea.Cmd) {
 			}
 			return m.executeAction("Detener Servicio", mgr.Stop)
 
-		case "force-stop":
+		case ActionForceStop:
 			mgr := m.getActiveManager()
 			if mgr == nil {
 				m.statusMessage = "No se pudo determinar el servicio a detener."
@@ -313,7 +313,7 @@ func (m Model) handleLogsKey(msg tea.KeyMsg) (tea.Model, tea.Cmd) {
 			m.statusMessage = "Abriendo carpeta de logs..."
 			return m, nil
 
-		case "back":
+		case ActionBack:
 			return m.returnToFamilyMenu()
 		}
 	}