🧪 Add tests for JobRateLimiter and make time deterministic#20
Conversation
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
⚡ Benchmark ResultsTo add benchmarks, create functions starting with |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
🎯 What: The
internal/server/rate_limit.gorate limiter was missing unit tests. Additionally, the existing implementation relied directly ontime.Now()preventing deterministic behavior in tests.📊 Coverage: I refactored the struct to have an injectable
now func() time.Time(defaulting totime.Now) and added tests that cover all allowance branches: passing when under limits, failing when over, expiring older entries from the time window, behaving independently between IP clients, and defaulting effectively whennowis nil. The line coverage onrate_limit.gois now 100%.✨ Result: We now have deterministic testing preventing rate-limit logic regressions. Abuse behavior can be verified correctly.
PR created automatically by Jules for task 3097189037211435559 started by @adcondev