Skip to content

fix: add eslint tooling for lint script - #10

Open
xianzuyang9-blip wants to merge 1 commit into
addyosmani:mainfrom
xianzuyang9-blip:codex/fix-lint-tooling
Open

fix: add eslint tooling for lint script#10
xianzuyang9-blip wants to merge 1 commit into
addyosmani:mainfrom
xianzuyang9-blip:codex/fix-lint-tooling

Conversation

@xianzuyang9-blip

Copy link
Copy Markdown

Summary

  • add ESLint as a dev dependency so the existing npm run lint script has a local binary after a clean install
  • add a flat ESLint config for the ESM Node source and tests
  • keep the lint baseline conservative by checking parse/undefined errors without forcing existing unused-variable cleanup into this tooling fix

Fixes #2

Verification

  • reproduced the clean-install failure before the fix: npm run lint failed with 'eslint' is not recognized as an internal or external command
  • npm ci --registry=https://registry.npmjs.org/ --replace-registry-host=never
  • npm run lint

Notes

  • npm test currently has an existing failure in test/checkers/skill-md.test.js (Expected score >= 5, got 0). I left that out of scope for this lint-tooling fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

npm run lint is broken: eslint is not in devDependencies and no config exists

2 participants