fix: add missing trailing newline to extmath.h - #2
Merged
adequate-systems merged 1 commit intoApr 2, 2026
Merged
Conversation
Clang on macOS with -Werror -Wnewline-eof treats a missing trailing newline as a hard error, breaking the macOS arm64 CI build for any project that includes this header.
Contributor
|
Single line change for Clang compatibility, no functional change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a missing trailing newline to
src/extmath.h.Why
Clang on macOS enables
-Wnewline-eofby default. Combined with-Werror, this causes a hard build failure on macOS arm64 CI:Breaks the macOS CI build for downstream projects (e.g.,
mochimodev/mochimo).Change
Single character: adds
\nat end of file after#endif.