Add Service SAS and Delete Blob support#1
Merged
Conversation
…ous improvements and fixes
afuersch
reviewed
Mar 6, 2026
| { | ||
| Directory.CreateDirectory(_storagePath); | ||
|
|
||
| _simulatorContainer = new ContainerBuilder("ghcr.io/adliance/azureblobsimulator:latest") |
Contributor
There was a problem hiding this comment.
The tests uses the latest image of the registry and not builds it from the current code. Is that on purpose?
Contributor
Author
There was a problem hiding this comment.
The idea was to test this as well. Do you think it would be better to test the current code? I wanted to cover a scenario that is as close as possible to a real-world one.
afuersch
reviewed
Mar 6, 2026
Contributor
afuersch
left a comment
afuersch
left a comment
There was a problem hiding this comment.
Using the Azure Storage Explorer I was not able to use the "Download all" or "Upload all" functionality. I always received a Forbidden error. That's something to put on the future backlog I guess.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances SAS support and blob deletion functionality, improves header handling, and expands automated test coverage.
Changes
2015-04-05through2018-11-08)Impact