Return configured container names#4
Merged
Conversation
5aa5778 to
6d59298
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When listing available containers, the name of the folder on disk was returned, instead of the configured container name. Therefore listing and then accessing containers failed in the client. Furthermore, configuring a container in the appsettings with the same name as the folder on disk lead to an exception.
This is fixed now and the returned list looks as expected.
@saxx Is this change a problem for any of our clients already consuming the simulator?
PS: The broken E2E test is fixed in #3 .
Before:

After:

Used config: