Add GetAssetAdministrationShellVersionByIdAndDate and GetSubmodelVersionByIdAndDate#540
Open
sebbader-sap wants to merge 4 commits intoIDTA-01002-3-2_workingfrom
Open
Conversation
sebbader-sap
requested review from
BirgitBoss,
aaronzi,
alexgordtop,
aorzelskiGH,
danielporta,
g1zzm0,
mdanish98,
mjacoby,
waltersve,
whamm86 and
zrgt
as code owners
|
|
whamm86
approved these changes
Mar 4, 2026
aaronzi
reviewed
Mar 5, 2026
Member
aaronzi
left a comment
aaronzi
left a comment
There was a problem hiding this comment.
The OpenAPI yaml files look good to me. But on the documentation side, I'm missing the following two things:
- Which field in the AAS (or underlying database) is used to find an AAS/Submodel by date? Is it
createdAtorupdatedAtfrom the new administrative-information in the metamodel or is this just a field that exists on the server but not in the AAS itself? - What happens if an AAS/Submodel is not found based on the given date? Is the most recent version from before that given date returned or a 404?
And a general remark here. Is it expected that when a new AAS/Submodel is created or updated that the server sets the createdAt and updatedAt fields on it's own or is just the user input used no matter if the given dates make actual sense? Should access rules be used here to only allow setting the createdAt during AAS/Submodel creation and updatedAt when the AAS/Submodel are updated?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.