change application/asset-administration-shell-package+xml to applicat…#542
Open
sebbader-sap wants to merge 1 commit intoIDTA-01002-3-2_workingfrom
Open
change application/asset-administration-shell-package+xml to applicat…#542sebbader-sap wants to merge 1 commit intoIDTA-01002-3-2_workingfrom
sebbader-sap wants to merge 1 commit intoIDTA-01002-3-2_workingfrom
Conversation
sebbader-sap
requested review from
BirgitBoss,
alexgordtop,
aorzelskiGH,
danielporta,
g1zzm0,
mjacoby,
waltersve and
zrgt
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Major Changes: | ||
|
|
||
| * ... | ||
| * Chaning the serialization format for AASX packages from "application/asset-administration-shell-package+xml" to "application/zip+xml" in the OpenAPI files for the Asset Administration Shell Repository Service Specification and the Submodel Repository Service Specification. This change is necessary to align with the actual content type used by implementations and to avoid confusion, as the previous content type was not registered and could be misinterpreted as an XML-based format. (https://github.com/admin-shell-io/aas-specs-api/issues/538[#538]) |
Check warning
Code scanning / QDJVMC
Typo Warning documentation
BirgitBoss
reviewed
Mar 4, 2026
| description: Requested serialization based on SerializationFormat | ||
| content: | ||
| application/asset-administration-shell-package+xml: | ||
| application/zip+xml: |
Collaborator
There was a problem hiding this comment.
In IANAapplication/aas+zip is registered. Now you additionally want to mention which format is within the zip-file, xml?
BirgitBoss
reviewed
Mar 4, 2026
| description: Requested serialization based on SerializationFormat | ||
| content: | ||
| application/asset-administration-shell-package+xml: | ||
| application/zip+xml: |
Collaborator
There was a problem hiding this comment.
BirgitBoss
reviewed
Mar 4, 2026
| description: Requested serialization based on SerializationFormat | ||
| content: | ||
| application/asset-administration-shell-package+xml: | ||
| application/zip+xml: |
Collaborator
There was a problem hiding this comment.
BirgitBoss
reviewed
Mar 4, 2026
| description: Requested serialization based on SerializationFormat | ||
| content: | ||
| application/asset-administration-shell-package+xml: | ||
| application/zip+xml: |
Collaborator
There was a problem hiding this comment.
BirgitBoss
reviewed
Mar 4, 2026
| description: Requested serialization based on SerializationFormat | ||
| content: | ||
| application/asset-administration-shell-package+xml: | ||
| application/zip+xml: |
Collaborator
There was a problem hiding this comment.
BirgitBoss
reviewed
Mar 4, 2026
| Major Changes: | ||
|
|
||
| * ... | ||
| * Chaning the serialization format for AASX packages from "application/asset-administration-shell-package+xml" to "application/zip+xml" in the OpenAPI files for the Asset Administration Shell Repository Service Specification and the Submodel Repository Service Specification. This change is necessary to align with the actual content type used by implementations and to avoid confusion, as the previous content type was not registered and could be misinterpreted as an XML-based format. (https://github.com/admin-shell-io/aas-specs-api/issues/538[#538]) |
Collaborator
There was a problem hiding this comment.
BirgitBoss
reviewed
Mar 4, 2026
| Major Changes: | ||
|
|
||
| * ... | ||
| * Chaning the serialization format for AASX packages from "application/asset-administration-shell-package+xml" to "application/zip+xml" in the OpenAPI files for the Asset Administration Shell Repository Service Specification and the Submodel Repository Service Specification. This change is necessary to align with the actual content type used by implementations and to avoid confusion, as the previous content type was not registered and could be misinterpreted as an XML-based format. (https://github.com/admin-shell-io/aas-specs-api/issues/538[#538]) |
Collaborator
There was a problem hiding this comment.
Suggested change
| * Chaning the serialization format for AASX packages from "application/asset-administration-shell-package+xml" to "application/zip+xml" in the OpenAPI files for the Asset Administration Shell Repository Service Specification and the Submodel Repository Service Specification. This change is necessary to align with the actual content type used by implementations and to avoid confusion, as the previous content type was not registered and could be misinterpreted as an XML-based format. (https://github.com/admin-shell-io/aas-specs-api/issues/538[#538]) | |
| * Changing the serialization format for AASX packages from "application/asset-administration-shell-package+xml" to "application/zip+xml" in the OpenAPI files for the Asset Administration Shell Repository Service Specification and the Submodel Repository Service Specification. This change is necessary to align with the actual content type used by implementations and to avoid confusion, as the previous content type was not registered and could be misinterpreted as an XML-based format. (https://github.com/admin-shell-io/aas-specs-api/issues/538[#538]) |
BirgitBoss
reviewed
Mar 4, 2026
| description: Requested serialization based on SerializationFormat | ||
| content: | ||
| application/asset-administration-shell-package+xml: | ||
| application/zip+xml: |
Collaborator
There was a problem hiding this comment.
BirgitBoss
reviewed
Mar 4, 2026
| description: Requested serialization based on SerializationFormat | ||
| content: | ||
| application/asset-administration-shell-package+xml: | ||
| application/zip+xml: |
Collaborator
There was a problem hiding this comment.
BirgitBoss
requested changes
Mar 4, 2026
Collaborator
BirgitBoss
left a comment
BirgitBoss
left a comment
There was a problem hiding this comment.
the registered type in IANA is application/aas+zip and not application/zip+xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ion/zip+xml
Solve #538