Skip to content

add new aas repo identifiable profile#545

Open
sebbader-sap wants to merge 1 commit intoIDTA-01002-3-2_workingfrom
SeBa/496-aas-repo-identifiable-profile
Open

add new aas repo identifiable profile#545
sebbader-sap wants to merge 1 commit intoIDTA-01002-3-2_workingfrom
SeBa/496-aas-repo-identifiable-profile

Conversation

@sebbader-sap
Copy link
Contributor

Close #496

|<<asset-administration-shell-repository-service-specification-service-specification-ssp-001,AssetAdministrationShellRepositoryServiceSpecification/SSP-001>> |Full feature set
|<<asset-administration-shell-repository-service-specification-service-specification-ssp-002,AssetAdministrationShellRepositoryServiceSpecification/SSP-002>> |Only read operations; is included in the profile AssetAdministrationShellRepositoryServiceSpecification/SSP-001
|<<asset-administration-shell-repository-service-specification-service-specification-ssp-003,AssetAdministrationShellRepositoryServiceSpecification/SSP-003>> |Query operations
|<<asset-administration-shell-repository-service-specification-service-specification-ssp-004,AssetAdministrationShellRepositoryServiceSpecification/SSP-004>> |Operations on Identifiables only; is included in the profile AssetAdministrationShellRepositoryServiceSpecification/SSP-001

Check warning

Code scanning / QDJVMC

Typo Warning documentation

Typo: In word 'Identifiables'
@mjacoby
Copy link
Collaborator

mjacoby commented Mar 2, 2026

There are some API calls that have been added/removed according to the proposal at #496 (comment)

✅ get /shells
✅ post /shells
✅ get /shells/{aasIdentifier}
✅ put /shells/{aasIdentifier}
✅ delete /shells/{aasIdentifier}
❌ get /shells/{aasIdentifier}/asset-information
❌ put /shells/{aasIdentifier}/asset-information
✅ get /shells/{aasIdentifier}/asset-information/thumbnail
✅ put /shells/{aasIdentifier}/asset-information/thumbnail
✅ delete /shells/{aasIdentifier}/asset-information/thumbnail
❌ get /shells/{aasIdentifier}/submodel-refs
❌ post /shells/{aasIdentifier}/submodel-refs
❌ delete /shells/{aasIdentifier}/submodel-refs/{submodelIdentifier}
✅ get /shells/{aasIdentifier}/submodels/{submodelIdentifier}
✅ put /shells/{aasIdentifier}/submodels/{submodelIdentifier}
✅ delete /shells/{aasIdentifier}/submodels/{submodelIdentifier}
🆕 get /shells/{aasIdentifier}/submodels/{submodelIdentifier}/submodel-elements/{idShortPath}/attachment
🆕 put /shells/{aasIdentifier}/submodels/{submodelIdentifier}/submodel-elements/{idShortPath}/attachment
🆕 delete /shells/{aasIdentifier}/submodels/{submodelIdentifier}/submodel-elements/{idShortPath}/attachment

What is the motivation for these deviations?
At first glance, I do not see any reason to not include the calls to /shells/{aasIdentifier}/asset-information and /shells/{aasIdentifier}/submodel-refs.

Regarding the calls to /shells/{aasIdentifier}/submodels/{submodelIdentifier}/submodel-elements/{idShortPath}/attachment I think I understand the intention, as without them no access to the files is possible at all. However, this feels like breaking the intention of the profile that no submodel element-level access should be supported. An alternative would be to add the serialization interface (which could be limited to AASX format) which then would enable access to files.

h|Profile Identifier: |`\https://admin-shell.io/aas/API/3/2/AssetAdministrationShellRepositoryServiceSpecification/SSP-004`
h|Feature h|Appearance
|API and API Operations a|
_AAS Repository API:_ +
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inconsistency

in the .yaml there are also contained but not listed here in text:

GetAllAssetAdministrationShells

Not contained in .yaml:
PostSubmodel

|xref:specification/interfaces-operation-parameters.adoc#SerializationModifier[SerializationModifier] a|
Level: Deep

Content: Normal
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why only Content "Normal", "Value" also and also the other formats, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants