Skip to content

Add examples for REFERENCE and APPEND only#47

Merged
Martin187187 merged 19 commits intoadmin-shell-io:IDTA-01004-3-1_Workingfrom
aorzelskiGH:aorzelski/issue37
Mar 3, 2026
Merged

Add examples for REFERENCE and APPEND only#47
Martin187187 merged 19 commits intoadmin-shell-io:IDTA-01004-3-1_Workingfrom
aorzelskiGH:aorzelski/issue37

Conversation

@aorzelskiGH
Copy link
Contributor

No description provided.

@aorzelskiGH aorzelskiGH changed the title Add example APPEND only Add examples for REFERENCE and APPEND only Jan 16, 2026
@BirgitBoss BirgitBoss self-requested a review January 20, 2026 07:38
$and(
REFERENCE($sme("SubmodelID-OperationalData").machineState#value) $eq "not-running",
$or(
$sm#semanticId $eq "SemanticID-Nameplate",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semanticId examples do not fit to "not-running", should be operational data

$and(
REFERENCE($sme("SubmodelID-OperationalData").machineState#value) $eq "not-running",
$or(
$sm#semanticId $eq "SemanticID-Nameplate",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$sm#semanticId $eq "SemanticID-Nameplate",
$sm#semanticId $eq "SemanticID-OperationalData",

REFERENCE($sme("SubmodelID-OperationalData").machineState#value) $eq "not-running",
$or(
$sm#semanticId $eq "SemanticID-Nameplate",
$sm#semanticId $eq "SemanticID-TechnicalData"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$sm#semanticId $eq "SemanticID-TechnicalData"
$sm#semanticId $eq "SemanticID-PerformanceData"

@@ -0,0 +1,12 @@
ACCESSRULE:

Check warning

Code scanning / QDJVMC

Typo Warning documentation

Typo: In word 'ACCESSRULE'
@@ -0,0 +1,9 @@
ACCESSRULE:

Check warning

Code scanning / QDJVMC

Typo Warning documentation

Typo: In word 'ACCESSRULE'
Copy link
Contributor

@BirgitBoss BirgitBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

examples are fine, only changelog update is missing

@Martin187187 Martin187187 self-assigned this Feb 17, 2026
@Martin187187 Martin187187 added the ready for review “Ready for review by the Task Force label Feb 23, 2026
}
],
"RIGHTS": [
"READ"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has APPEND in the title, but no new examples use the "APPEND" keyword. Does this example should example use APPEND? There is no APPEND Right yet.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on information of previous disucussions: no keyword APPEND is planned. But I assume this example want CREATE instead of READ

@Martin187187
Copy link
Collaborator

closes #29

@Martin187187
Copy link
Collaborator

tries to solve (title) #37, but does not!

@Martin187187
Copy link
Collaborator

Martin187187 commented Feb 23, 2026

now closes #37 aswell.

@Martin187187 Martin187187 merged commit 3339b3f into admin-shell-io:IDTA-01004-3-1_Working Mar 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review “Ready for review by the Task Force

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants