Skip to content

fix: (UGP-14675) add fallback ID extraction in slides block for V2 co… - #2502

Open
vik407 wants to merge 2 commits into
mainfrom
UGP-14675
Open

fix: (UGP-14675) add fallback ID extraction in slides block for V2 co…#2502
vik407 wants to merge 2 commits into
mainfrom
UGP-14675

Conversation

@vik407

@vik407 vik407 commented Mar 12, 2026

Copy link
Copy Markdown
Collaborator

…nverter transition

Adds a fallback path in slides.js decorate() to handle transitional pages where the V2 converter previously emitted
a fragment block with an anchor <a href="/en/slides/{id}"> instead of a slides block with a bare ID.

The root fix is in exl-html-converter (separate PR) — the markdownit plugin now outputs the correct slides block
with a bare ID.

This fallback protects against:
Pages already cached in CDN with the old fragment-style output that get re-decorated after a CDN miss
Any edge environment where the old converter output persists temporarily

Jira ID: UGP-14675

Test URLs:

@vik407
vik407 requested a review from ajaydwarkani March 12, 2026 21:05
@aem-code-sync

aem-code-sync Bot commented Mar 12, 2026

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync

aem-code-sync Bot commented Mar 12, 2026

Copy link
Copy Markdown
Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /en/browse?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /en/browse?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /en/browse/analytics?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /en/browse/analytics?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /en/docs?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /en/docs?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /en/docs/analytics-learn/tutorials/exporting/data-feeds/find-your-data-feed-id=o
ff
Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/plain). PSI
🖥️ /en/docs/analytics-learn/tutorials/exporting/data-feeds/find-your-data-feed-id=o
ff
Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/plain). PSI

@vik407
vik407 requested a review from mblawrence March 12, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant