Skip to content

PII masking for profile picture - #2788

Open
ruhisingh1 wants to merge 1 commit into
mainfrom
pp-masking
Open

PII masking for profile picture#2788
ruhisingh1 wants to merge 1 commit into
mainfrom
pp-masking

Conversation

@ruhisingh1

@ruhisingh1 ruhisingh1 commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Please provide the Jira Issue your PR is for.

Jira ID:

Test URLs:

AI Review Notes

@aem-code-sync

aem-code-sync Bot commented Jul 15, 2026

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run all PSI checks
  • Re-run failed PSI checks
  • Re-sync branch
Commits

@aem-code-sync

aem-code-sync Bot commented Jul 15, 2026

Copy link
Copy Markdown
Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@claude

claude Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Reviewed the PII masking changes for profile pictures.

What changed

Adds data-cs-mask to the profile-picture <img> elements in adobe-account-card.js, header-v2.js, profile-menu.js, profile-welcome.js, and scripts/profile/profile.js, plus two new .gitignore entries (docs/*, plans/*).

Findings

No blocking or correctness issues found.

  • The data-cs-mask attribute usage is consistent with the existing masking convention already used elsewhere in the codebase for PII (profile-welcome.js, adobe-account-card.js, email-card.js, course-completion.js, and the [data-cs-mask] cleanup in browse-card-utils.js), so this is a correct, low-risk extension of that pattern to images.
  • Minor/non-blocking style nit: the new attribute is written as data-cs-mask/> (no space before the self-closing slash) in all four <img> cases, unlike the existing alt="..." /> spacing. It parses fine in HTML, so this is cosmetic only.
  • The .gitignore additions (docs/*, plans/*) are unrelated to the PII masking scope of this PR — worth double-checking they're intentional, though harmless either way.

No inline comments posted since nothing rises to a blocking or actionable-fix level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants