Skip to content

feat: (AIME-194) route /es/ Brand Concierge to the Spanish datastream - #2798

Merged
ruhisingh1 merged 1 commit into
exlm-bc-spanish-uifrom
exlm-bc-es-datastream
Jul 22, 2026
Merged

feat: (AIME-194) route /es/ Brand Concierge to the Spanish datastream#2798
ruhisingh1 merged 1 commit into
exlm-bc-spanish-uifrom
exlm-bc-es-datastream

Conversation

@eliwangj

@eliwangj eliwangj commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Jira ID: AIME-194

Stacked on #2791 (base branch exlm-bc-spanish-ui) — this PR is only the backend routing; the UI localization lives in #2791. Review/merge #2791 first; GitHub will retarget this to main once #2791 merges.

Summary

Routes the Brand Concierge conversation on /es/ to the Spanish concierge datastream instead of the default English one. Same IMS org, so only the datastream ID changes per locale.

  • brand-concierge-config.js: add datastreamId to the es overlay in BC_LOCALES and surface it from resolveBrandConciergeConfig().
  • brand-concierge.js: in initBrandConcierge(), configure the alloyBC instance with activeConfig.datastreamId ?? bcDatastreamId. English and other locales are unchanged.

Verification

Confirmed locally (aem up) by inspecting the Edge Interact request:

  • /es/browseedge.adobedc.net/…/v1/interact?configId=3098f7cc-… (Spanish datastream), HTTP 200
  • /en/browse…?configId=87ae6de9-… (default datastream), HTTP 200

Reviewer note: a Spanish question in the widget should now be answered by the Spanish manifest — please confirm the response content/citations come from the Spanish concierge.

AI Review Notes

  • Datastream ID is intentionally a config literal (matching the existing bcDatastreamId); same IMS org, production-ready.

🤖 Generated with Claude Code

On /es/ pages, configure the alloyBC instance with the Spanish concierge
datastream (3098f7cc-…, same IMS org) instead of the default, so conversations
reach the Spanish concierge/manifest. The locale datastream is resolved from
BC_LOCALES via resolveBrandConciergeConfig(); other locales keep the default.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@eliwangj
eliwangj requested a review from ajaydwarkani July 21, 2026 21:23
@aem-code-sync

aem-code-sync Bot commented Jul 21, 2026

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run all PSI checks
  • Re-run failed PSI checks
  • Re-sync branch
Commits


// Route to the locale's Brand Concierge datastream (e.g. the Spanish concierge on /es/),
// falling back to the default datastream for locales without an override.
const datastreamId = activeConfig.datastreamId ?? bcDatastreamId;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

activeConfig (with this new datastreamId key) is later spread wholesale into stylingConfigurations in getBootstrapOptions() (line 445), which only strips out stickySession and ui before forwarding the rest to the third-party BC web client via concierge.bootstrap().

Since resolveBrandConciergeConfig() now puts datastreamId at the top level of the returned config (brand-concierge-config.js:257), for the es locale it rides along into stylingConfigurations and gets sent to window.adobe.concierge.bootstrap() as if it were a styling/text value — it isn't destructured out the way ui is. English is unaffected (no datastreamId in the base config), so this is scoped to the new es path.

Likely harmless if the web client ignores unknown keys, but it's an unintended leak of internal routing config into the third-party client payload. Consider destructuring datastreamId out in getBootstrapOptions() alongside ui, or keeping it out of the resolveBrandConciergeConfig() return shape (e.g. a separate lookup) so it can't leak into stylingConfigurations.

@eliwangj

Copy link
Copy Markdown
Collaborator Author

overall experience:
image

@eliwangj

Copy link
Copy Markdown
Collaborator Author

noticed that the citation section still shows "sources" and points to english resources
image

@ruhisingh1
ruhisingh1 merged commit 01a35a9 into exlm-bc-spanish-ui Jul 22, 2026
3 of 4 checks passed
@ruhisingh1
ruhisingh1 deleted the exlm-bc-es-datastream branch July 22, 2026 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants