fix(EXLM-5517): Filter out stale upcoming events on Browse all page - #2842
Draft
gauthamksn wants to merge 1 commit into
Draft
fix(EXLM-5517): Filter out stale upcoming events on Browse all page#2842gauthamksn wants to merge 1 commit into
gauthamksn wants to merge 1 commit into
Conversation
The Coveo base advanced-query for /en/browse (BASE_COVEO_ADVANCED_QUERY) and its Events-V2 counterpart (BASE_COVEO_ADVANCED_QUERY_UPCOMING_EVENT) never applied a date check, so events tagged "Upcoming Event" kept showing after they'd already occurred. Both now reuse the existing COVEO_UPCOMING_EVENT_STILL_FUTURE_AQ / COVEO_EXCLUDE_STALE_UPCOMING_AQ helpers already relied on by the events-search and atomic-search blocks, so stale upcoming events are excluded consistently everywhere. Resolves: EXLM-5517
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please provide the Jira Issue your PR is for.
Jira ID: EXLM-5517
🤖 Auto-generated draft from Jira. Review before marking ready.
What was implemented
The
/en/browsepage's base Coveo advanced-query (BASE_COVEO_ADVANCED_QUERY) and its Events-V2 counterpart (BASE_COVEO_ADVANCED_QUERY_UPCOMING_EVENT) inscripts/browse-card/browse-cards-constants.jsnever applied a date check, so events tagged "Upcoming Event" kept showing after they'd already occurred. Both constants now reuse the existingCOVEO_UPCOMING_EVENT_STILL_FUTURE_AQ/COVEO_EXCLUDE_STALE_UPCOMING_AQhelpers already relied on by theevents-searchandatomic-searchblocks, so stale upcoming events are excluded consistently everywhere. Onlyscripts/browse-card/browse-cards-constants.jswas touched;npm run lintpasses clean.node --checksyntax validation, and manual boolean-logic verification of the Coveoaqstring construction.COVEO_UPCOMING_EVENT_STILL_FUTURE_AQ(EXLM-5361), this date filter only takes effect if the Coveo fieldel_event_start_timeis configured as Date type in the index — if it's still String,>= nowis a no-op and stale events will still appear. That's a Coveo-admin/schema change outside this repo's scope; please confirm the field type in production before/after merging.el_event_start_time(event start), matching the pre-existing pattern used byevents-search/atomic-search/upcoming-event-v2. A multi-day event that has started but not yet ended would now be excluded once its start time passes. Flagging in case "still in progress" events are expected to remain visible under "Upcoming Events" — that would need a separate end-date comparison.Test URLs:
Before: https://main--exlm--adobe-experience-league.aem.live
After: https://exlm-5517--exlm--adobe-experience-league.aem.live
After: https://exlm-5517--exlm--adobe-experience-league.aem.live/en/browse?martech=off
After: https://exlm-5517--exlm--adobe-experience-league.aem.live/en/browse/analytics?martech=off
After: https://exlm-5517--exlm--adobe-experience-league.aem.live/en/events?martech=off
After: https://exlm-5517--exlm--adobe-experience-league.aem.live/en/search?martech=off
AI Review Notes