You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.
Reviewed the change in scripts/scripts.js that adds a /support/v2/ path check to fix the Premium Learning link locale mapping.
Finding (see inline comment):plSupportV2LangsMap (lines 808-819) is identical to plCommunityLangsMap (lines 795-806) — same keys/values, and both branches of the new lang IIFE use the same fallback (rawLang.split('-')[0]). Suggest reusing plCommunityLangsMap in both branches instead of maintaining two maps that must be kept in sync by hand.
Note: my inline suggestion only removes the duplicate map declaration — applying it alone would leave a dangling reference to plSupportV2LangsMap at line 840 (in the lang resolver) and break at runtime. The accompanying change (swap that reference to plCommunityLangsMap) needs to be made together with it.
No other correctness issues found — the fix logic itself (checking pathname before hostname, falling back to rawLang.split('-')[0]) looks correct for the Support v2 case.
The previously flagged duplicate-map issue (plSupportV2LangsMap vs plCommunityLangsMap) was addressed in review comments — the author confirmed it's intentional to allow the Support language set to diverge from Community's in the future. Not re-flagging.
Checked the new pathname-based branch (window.location.pathname.includes('/support/v2/')) for correctness: it's evaluated before the community-host check, uses the same rawLang.split('-')[0] fallback, and doesn't change behavior for non-support-v2 paths. No logic errors found.
Note (non-blocking, not filed inline since it's speculative): the resulting lang value from this IIFE also feeds unrelated URL builders further down in getConfig() (browseMoreProductsLink, eventsURL, automaticTranslationLink, premiumHomeUrl), not just the Premium Learning API calls. This mirrors the pre-existing behavior for the Community host branch, so it's likely intentional/consistent, but worth a quick sanity check that Support v2 pages expect two-letter lang codes in those other URLs too.
No new blocking issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please provide the Jira Issue your PR is for.
Jira ID:
Test URLs:
Before: https://main--exlm--adobe-experience-league.aem.live
After: https://support-hotfix--exlm--adobe-experience-league.aem.live?martech=off
AI Review Notes