feat(EXLM-5507): show all filter options in events-search, remove scroll bar - #2846
Open
gyesireddy wants to merge 1 commit into
Open
feat(EXLM-5507): show all filter options in events-search, remove scroll bar#2846gyesireddy wants to merge 1 commit into
gyesireddy wants to merge 1 commit into
Conversation
…oll bar Removed the purely visual 11-item cap (MAX_VISIBLE_FILTER_OPTIONS, applyFilterOptionsScrollCap, recalcExpandedFilterScrollCaps, and their call sites incl. a ResizeObserver) on the Product/Series filter dropdowns in the events-search block, along with the now-dead scrollbar CSS. All facet values were already rendered in the DOM; expanding a group now shows the full list with no cap. Resolves: EXLM-5507
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please provide the Jira Issue your PR is for.
Jira ID: EXLM-5507
Test URLs:
Before: https://main--exlm--adobe-experience-league.aem.live
After: https://exlm-5507--exlm--adobe-experience-league.aem.live
After: https://exlm-5507--exlm--adobe-experience-league.aem.live/en/events?martech=off
Description
Removes the artificial 11-item visual cap and scrollbar on the Product/Series filter dropdowns in the events-search block (Events Hub V2, /en/events). All facet options were already rendered in the DOM — the cap only set an inline max-height via JS. Expanding a filter group now shows the full list of options with no scrollbar.
AI Review Notes