Skip to content

EXLM-5488 Remove paths.yaml - #2852

Draft
ruhisingh1 wants to merge 3 commits into
mainfrom
exlm-5488
Draft

EXLM-5488 Remove paths.yaml#2852
ruhisingh1 wants to merge 3 commits into
mainfrom
exlm-5488

Conversation

@ruhisingh1

@ruhisingh1 ruhisingh1 commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Please provide the Jira Issue your PR is for.

Jira ID:

Test URLs:

AI Review Notes

@aem-code-sync

aem-code-sync Bot commented Aug 11, 2026

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run all PSI checks
  • Re-run failed PSI checks
  • Re-sync branch
Commits

@ruhisingh1
ruhisingh1 marked this pull request as draft August 11, 2026 08:12
@aem-code-sync

aem-code-sync Bot commented Aug 11, 2026

Copy link
Copy Markdown
Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@claude

claude Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

CI-breaking issue: this PR deletes validate-paths.js and paths.yaml, and updates AGENTS.md/docs/prompt-library.md to describe npm run quality as just "format check + lint" — but package.json still has:

"validate:paths": "node validate-paths.js",
"quality": "npm run format:check && npm run lint && npm run validate:paths",

Since validate-paths.js no longer exists, npm run validate:paths will fail with MODULE_NOT_FOUND, and npm run quality (the CI gate run by .github/workflows/quality-action.yaml) will fail as a result. package.json needs to drop the validate:paths script and remove it from the quality script's command chain to match the docs and actually ship a working npm run quality.

(Also worth a look, non-blocking: js-yaml is now unused in devDependencies since it was only used by validate-paths.js.)

Comment thread docs/prompt-library.md
@@ -38,7 +38,6 @@ For deeper standalone prompts that lean entirely on MCP tools, see [§18 — MCP
- [11. Testing](#11-testing)
- [12. Self-review before commit](#12-self-review-before-commit)
- [13. Commits, branches, and PR hygiene](#13-commits-branches-and-pr-hygiene)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting the 14. paths.yaml / paths.json sync TOC entry here shifted every later section down by one in the body (Debugging is now ## 14., Documentation and handover is now ## 15., Cross-cutting integrations is ## 16., MCP-aware variants is ## 17. — confirmed further down in this diff), but the TOC entries right below this line weren't renumbered to match:

- [15. Debugging](#15-debugging)
- [16. Documentation and handover](#16-documentation-and-handover)
- [17. Cross-cutting integrations (Coveo, feature flags, locales)](#17-cross-cutting-integrations-coveo-feature-flags-locales)
- [18. MCP-aware variants](#18-mcp-aware-variants)

These should become 14./15./16./17. respectively (and their anchors), or the links will point at the wrong section / a dead anchor.

@claude

claude Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Following up on the TOC renumbering issue flagged inline at docs/prompt-library.md:40 — the same stale-numbering problem shows up in several cross-references scattered through the file that fall outside the diff hunks (so I can't leave inline comments on them), but they still point at the pre-renumbering section numbers/anchors:

  • line 17: (see §15.3) → should be §14.3
  • line 19: (§13) → still correct (Commits/branches/PR hygiene wasn't renumbered)
  • line 21: [§18 — MCP-aware variants](#18-mcp-aware-variants) → should be §17 / #17-mcp-aware-variants
  • line 179: [§18.1](#181-new-block-from-a-figma-frame-figma-mcp--end-to-end) → should be §17.1 / #171-...
  • line 1013: see §15.3 → should be §14.3
  • lines 1053-1063 (the "MCP servers" table/heading near the end): all the §18/§18.x references → should be §17/§17.x

Worth a repo-wide pass over docs/prompt-library.md for §1[4-8] / #1[4-8]- references to catch anything else left over from the section-14 deletion.

@claude

claude Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Code review: one minor leftover cleanup item.

package.json — the js-yaml devDependency (line 42) was only used by validate-paths.js, which this PR deletes. No other file in the repo references js-yaml, so it can be removed as well. (Not inline-commentable since that line isn't part of the diff.)

Previously flagged issues (the quality/validate:paths script breakage and the docs/prompt-library.md TOC/section renumbering) are confirmed fixed in the current HEAD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant