chore: rename e2e env vars from CONSOLEAPI_* to CONSOLE_API_* and add missing var check#125
Open
shazron wants to merge 10 commits intoremove-axios-form-datafrom
Open
chore: rename e2e env vars from CONSOLEAPI_* to CONSOLE_API_* and add missing var check#125shazron wants to merge 10 commits intoremove-axios-form-datafrom
shazron wants to merge 10 commits intoremove-axios-form-datafrom
Conversation
… missing var check Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… files - Add jest.globalSetup.js: validates required env vars once before all suites - Add jest.setup.js: initialises sdkClient and orgId as globals, exposes apiKey, accessToken, imsOrgId, env, findSDKCode, expectOkResponse - Update jest.config.js: wire up globalSetup and new setupFilesAfterEnv, restrict testRegex to e2e.js only for now - Remove duplicated boilerplate (dotenv, env validation, sdk init, orgId lookup, findSDKCode) from e2e.js and e2e.credentials.js Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
moritzraho
approved these changes
Apr 2, 2026
shazron
commented
Apr 2, 2026
mgar
approved these changes
Apr 2, 2026
dthampy
reviewed
Apr 2, 2026
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CONSOLEAPI_*environment variables toCONSOLE_API_*ine2e/e2e.js,e2e/.env.example, ande2e/README.mdCONSOLE_API_API_KEY,CONSOLE_API_ACCESS_TOKEN,CONSOLE_API_IMS_ORG_ID);CONSOLE_API_ENVis excluded since it defaults toprodnpm run e2epassesBase branch
This PR is based on
remove-axios-form-data(#124), notmaster. It is stacked on top of that branch.Reconciling when the base branch is merged
Once #124 is merged into
master, retarget this PR tomasterand rebase:Then change the base branch of this PR from
remove-axios-form-datatomaster(via the GitHub UI orgh pr edit <number> --base master). The diff will then show only the changes in this PR.Test plan
e2e/.env.exampletoe2e/.env, populate with valid values, and runnpm run e2e🤖 Generated with Claude Code