Skip to content

[prototype, for discussion] Add a node-redis backed connection alongside ioredis #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
DavideCarvalho wants to merge 1 commit into
base: 11.x
Choose a base branch
from
Draft

[prototype, for discussion] Add a node-redis backed connection alongside ioredis #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions factories/redis_manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,13 @@

import RedisManager from '../src/redis_manager.ts'
import { LoggerFactory } from '@adonisjs/core/factories/logger'
import type { RedisClusterConnectionConfig, RedisConnectionConfig } from '../src/types.ts'
import type { RedisConnectionsList } from '../src/types.ts'

/**
* Redis manager factory is used to create an instance of the redis
* manager for testing
*/
export class RedisManagerFactory<
ConnectionsList extends Record<string, RedisClusterConnectionConfig | RedisConnectionConfig>,
> {
export class RedisManagerFactory<ConnectionsList extends RedisConnectionsList> {
#config: {
connection: keyof ConnectionsList
connections: ConnectionsList
Expand Down
1 change: 1 addition & 0 deletions index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,6 @@ export { RedisCheck } from './src/checks/redis_check.ts'
export * as tracingChannels from './src/tracing_channels.ts'
export { default as RedisManager } from './src/redis_manager.ts'
export { RedisConnection } from './src/connections/redis_connection.ts'
export { NodeRedisConnection } from './src/connections/node_redis_connection.ts'
export { RedisMemoryUsageCheck } from './src/checks/redis_memory_usage_check.ts'
export { RedisClusterConnection } from './src/connections/redis_cluster_connection.ts'
130 changes: 106 additions & 24 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 8 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
"dotenv": "^17.4.2",
"eslint": "^10.8.1",
"prettier": "^3.9.6",
"redis": "^6.2.1",
"release-it": "^21.0.2",
"tsdown": "^0.22.14",
"typescript": "^5.9.3"
Expand All @@ -69,7 +70,13 @@
"ioredis": "^6.0.0"
},
"peerDependencies": {
"@adonisjs/core": "^7.0.0-next.0 || ^7.0.0"
"@adonisjs/core": "^7.0.0-next.0 || ^7.0.0",
"redis": "^5.0.0 || ^6.0.0"
},
"peerDependenciesMeta": {
"redis": {
"optional": true
}
},
"keywords": [
"redis",
Expand Down
Loading