Open
Conversation
…text' (#44) * fix: fixed error: ‘class v8::Object’ has no member named ‘CreationContext’; allowing node-gyp to rebind with node-postal, which enables node-postal to be used on Node v20.5.0 * feat: add node v16 and v20 to github actions matrix * fix: updated workflow script to run on push and pull request events * fix: updated actions/checkout@v2 to v3 as the former was deprecated * test: trying to get the bindings file made/located correctly * fix: removed incorrect cd step * feat: added fail-fast so jobs will continue running after a node version test fails in the matrix * feat/test: set the context depending on the node version; node v16+ use new update, else use old way * fix/test: added node version header to expand.cc and parser.cc * test: changed node_version header to node header * fix: reverting back to state where node 16,18,20 tests worked... * fix/test: reverted github actions to v2 from v3... * test: attempt to get tests to pass for node v16+ * fix: re-added line in ParseAddress that had been incorrectly removed * fix: depending on node version call the right context function * fix: removed typo
* feat(deps): Update NAN to v2.22 This is required for Node.js 22 support * CI: Add Node.js 22 to CI
* Test on Node.js v23 * Lose the arm * actions/checkout@v4
```diff + - os: ubuntu-24.04-arm + node-version: 22.x + status: 'current' ```
* [Keeping your actions up to date with Dependabot](https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot) * [Configuration options for the dependabot.yml file - package-ecosystem](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#package-ecosystem)
…s group (#56) * Bump actions/setup-node in the github-actions group Bumps the github-actions group with 1 update: [actions/setup-node](https://github.com/actions/setup-node). Updates `actions/setup-node` from 2.pre.beta to 4.1.0 - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v2-beta...v4.1.0) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> * Update .github/workflows/push.yml Co-authored-by: Christian Clauss <cclauss@me.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Peter Johnson <insomnia@rcpt.at> Co-authored-by: Christian Clauss <cclauss@me.com>
Instead of manually freeing the memory allocated by `libpostal_expand_address()`, use `libpostal_expansion_array_destroy()` to free the memory. This is how example program from libpostal frees the memory. For more details, please refer to this issue: openvenues/libpostal#682
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.