Skip to content

[WIP] Modernise ember-leaflet - #705

Closed
MichalBryxi wants to merge 8 commits into
adopted-ember-addons:masterfrom
MichalBryxi:mb/hotfixes-from-abefordisc-3
Closed

MichalBryxi wants to merge 8 commits into
adopted-ember-addons:masterfrom
MichalBryxi:mb/hotfixes-from-abefordisc-3

Conversation

@MichalBryxi

@MichalBryxi MichalBryxi commented Apr 23, 2025 •

Copy link
Copy Markdown
  • WIP!
  • This is to start fixing things to allow the addon users upgrade their apps
  • First step to be able to convert the addon to v2

TODOs

@jelhan

jelhan commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

@MichalBryxi This addon has been adopted. I started modernizing. If you have time, please check if something from this PR should still go in. Or if it was fully done by #702 already.

All other contributions to get this addon to a modern v2 addon are highly welcome as well.

@MichalBryxi

Copy link
Copy Markdown
Author

@jelhan \o/ yay! Thank you! This contained just a set of critical changes to get it to v2 addon. So as long as you get there somehow, it should be grand. Thanks again!

@MichalBryxi MichalBryxi closed this Jul 3, 2026
@jelhan

jelhan commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

@jelhan \o/ yay! Thank you! This contained just a set of critical changes to get it to v2 addon. So as long as you get there somehow, it should be grand. Thanks again!

Thanks a lot for reviewing. I fear getting to v2 addon may not be that easy. The design if the componentsToYield doesn't seem to play well with Embroider unless using ensure-safe-component helper. My current goal is to make it work in a modern Ember stack. Bit I'm not sure if I have enough time for refactoring it to allow shipping as v2 addon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants