perf(tracker): batch fused location delivery to cut wakeups#223
Draft
adsamcik wants to merge 1 commit into
Draft
perf(tracker): batch fused location delivery to cut wakeups#223adsamcik wants to merge 1 commit into
adsamcik wants to merge 1 commit into
Conversation
Add setMaxUpdateDelayMillis (3x the collection interval) to the fused location request in both onEnable and updateInterval, refactored into a shared buildLocationRequest helper. This lets the OS coalesce several fixes into one delivery when power-efficient (screen-off / Doze-adjacent), reducing radio and CPU wakeups. Delivery stays prompt while interactive, and onNewData already filters/persists each fix in a batch so per-fix timestamps are preserved. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Battery follow-up from the tracking-architecture review (P2). The fused location request never set
setMaxUpdateDelayMillis, so the device wakes for every fix even when nobody is looking at the screen.Change
setMaxUpdateDelayMillis(interval × 3)to the fusedLocationRequestin bothonEnableandupdateInterval, refactored into a sharedbuildLocationRequest(...)helper (removes duplication).onNewDataalready accepts aList<Location>and filters/persists each fix with its own timestamp, so route reconstruction is unaffected by when a batch is delivered. The3×factor bounds worst-case delivery latency.Why a constant factor (and not passive / tier-aware priority)
AmbientCollectionTrigger), so a "passive listener for AMBIENT" is a separate, more architectural change (tracked as an issue), not a tweak to this trigger.Priority(e.g.LOW_POWERfor ECONOMY) would require threading the tier throughDynamicIntervalCollectionTrigger.updateInterval(...); kept out of this PR to stay focused and low-risk.Verification
./gradlew :tracker:engine:compileDebugKotlin— BUILD SUCCESSFUL.Notes
Draft — opened for review.
setMaxUpdateDelayMillisis part of the GMSLocationRequest.Builderalready used here.