Fix repeated records in ANPP decoders - #22
Merged
mattia-adnav merged 1 commit intoAug 25, 2026
Merged
mattia-adnav merged 1 commit into
mattia-adnav merged 1 commit into
Conversation
mark-lawrenson
force-pushed
the
codex/fix-anpp-repeated-record-decoding
branch
from
July 22, 2026 11:00
77ea7d4 to
b90f9ae
Compare
mark-lawrenson
changed the title
mattia-adnav
requested changes
Aug 25, 2026
mattia-adnav
left a comment
mattia-adnav
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for reporting and fixing this issue!
Please rebase and look at the other comments.
mark-lawrenson
force-pushed
the
codex/fix-anpp-repeated-record-decoding
branch
from
August 25, 2026 03:23
b90f9ae to
7285418
Compare
Contributor
Author
|
Thanks @mattia-adnav! I have rebased onto master, updated both copyright years, and ran |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Several packet decoders initialise record lists using
[Record()] * count. Every item then refers to the same object, so decoding overwrites the earlier records and returns the final record multiple times. This affects Packets 31, 60, 84, 181, and 202.The existing
Log.anppfixture shows the problem: Packet 202 contains four different ports, but the current decoder returns four copies of the final port. Packet 181 does the same with its two period records.Change
Tests
The regression tests cover each affected record list and Packet 60 satellite
data with frequency counts of 2, 1, and 2. All 290 tests pass.