3.6.0: backport MINGW support - #2938
Open
ivan-mogilko wants to merge 8 commits into
Open
ivan-mogilko wants to merge 8 commits into
ivan-mogilko wants to merge 8 commits into
Conversation
this cast is not required on MSVC.
`__except` is not supported on mingw and will require a different code for exception handling. I found working code but it used an undocumented nt api, so this is better to research with calm.
this is to avoid manually copying mingw dlls, and ensures a portable binary the same as traditional acwin.exe
Member
|
I think you need to also pull b08ced9 for the GHA CI to succeed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One person needed to build the 3.6.0 engine in MSYS2 environment. This PR is a backport of fixes done for 3.6.1 (#2196).