[02/n] Add ParseContext context manager, wire in toml#2
Merged
Conversation
This is the most public API -- with this context manager active, any exception that's raised will be examined for a JSONPath string in its message. This was chosen because it's what msgspec generates today, and improving those errors is the first goal. Modeling our source map after json-source-map, we store the keys as JSONPointer (which is a simpler, non-query-focused dialect). We now have a converter between them that works for the common case.
thatch
force-pushed
the
02-parse-context
branch
from
67f6e6e to
b52bf6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the most public API -- with this context manager active, any exception that's raised will be examined for a JSONPath string in its message. This was chosen because it's what msgspec generates today, and improving those errors is the first goal.
Modeling our source map after json-source-map, we store the keys as JSONPointer (which is a simpler, non-query-focused dialect). We now have a converter between them that works for the common case.