fix(docker compose): remove /data in postgres mount#918
Closed
armanddidierjean wants to merge 1 commit intomainfrom
Closed
fix(docker compose): remove /data in postgres mount#918armanddidierjean wants to merge 1 commit intomainfrom
armanddidierjean wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #918 +/- ##
=======================================
Coverage 84.87% 84.87%
=======================================
Files 193 193
Lines 13895 13895
=======================================
Hits 11793 11793
Misses 2102 2102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Rotheem
approved these changes
Dec 7, 2025
Marc-Andrieu
reviewed
Dec 8, 2025
Comment on lines
3
to
18
| image: postgres | ||
| container_name: hyperion-db-dev | ||
| restart: unless-stopped | ||
| environment: | ||
| POSTGRES_HOST: ${POSTGRES_HOST} | ||
| POSTGRES_PASSWORD: ${POSTGRES_PASSWORD} | ||
| POSTGRES_USER: ${POSTGRES_USER} | ||
| POSTGRES_DB: ${POSTGRES_DB} | ||
| PGTZ: ${POSTGRES_TZ} | ||
| ports: | ||
| - 5432:5432 | ||
| volumes: | ||
| - hyperion_db_data:/var/lib/postgresql/data | ||
| - hyperion_db_data:/var/lib/postgresql | ||
|
|
||
| hyperion-redis: | ||
| image: redis |
Member
There was a problem hiding this comment.
Consider instead setting explicit version tags, for consistency with the other Hyperion-related compose files. This issue seems specific to the new major Postgres 18.
Suggested change
| image: redis | |
| image: postgres:15.1 | |
| container_name: hyperion-db-dev | |
| restart: unless-stopped | |
| environment: | |
| POSTGRES_HOST: ${POSTGRES_HOST} | |
| POSTGRES_PASSWORD: ${POSTGRES_PASSWORD} | |
| POSTGRES_USER: ${POSTGRES_USER} | |
| POSTGRES_DB: ${POSTGRES_DB} | |
| PGTZ: ${POSTGRES_TZ} | |
| ports: | |
| - 5432:5432 | |
| volumes: | |
| - hyperion_db_data:/var/lib/postgresql/data | |
| hyperion-redis: | |
| image: redis:7.0-alpine |
Member
There was a problem hiding this comment.
completely broken GH interface...
Member
|
Superseded by #950 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
The change is required for the latest postgresql image
Issues/PR dependencies
Issues to be resolved
Required PRs
Changes Made
Additional Notes
Classification
Type of Change
Impact & Scope
Testing
Documentation
"Docstrings#Inline comments